Conversation
Member
vjik
commented
Mar 21, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
============================================
+ Coverage 98.57% 98.59% +0.02%
- Complexity 366 372 +6
============================================
Files 48 48
Lines 983 998 +15
============================================
+ Hits 969 984 +15
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new QueueProviderInterface::getNames() API to expose configured queue names, and updates queue providers and CLI commands to use it for default queue argument values.
Changes:
- Add
QueueProviderInterface::getNames(): arrayand implement it across all built-in queue providers and the debug proxy. - Update
RunCommandandListenAllCommandto default theirqueueargument to$queueProvider->getNames()(removing the injected$queuesconstructor argument). - Add/adjust unit tests to cover
getNames()across providers and proxy, and update command tests accordingly.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Provider/QueueProviderInterface.php | Adds getNames() to the provider contract. |
| src/Provider/QueueFactoryProvider.php | Caches and returns definition keys via getNames(). |
| src/Provider/PredefinedQueueProvider.php | Returns array_keys($this->queues) via getNames(). |
| src/Provider/CompositeQueueProvider.php | Aggregates names from child providers (needs empty-case fix). |
| src/Provider/AdapterFactoryQueueProvider.php | Caches and returns adapter definition keys via getNames(). |
| src/Debug/QueueProviderInterfaceProxy.php | Delegates getNames() to the underlying provider. |
| src/Command/RunCommand.php | Removes injected queues list; defaults CLI args from getNames(). |
| src/Command/ListenAllCommand.php | Removes injected queues list; defaults CLI args from getNames(). |
| config/di.php | Removes obsolete DI wiring for the removed $queues constructor args. |
| tests/Unit/Provider/QueueFactoryProviderTest.php | Adds getNames() tests. |
| tests/Unit/Provider/PredefinedQueueProviderTest.php | Adds getNames() tests. |
| tests/Unit/Provider/CompositeQueueProviderTest.php | Adds getNames() tests (including empty/dupe cases). |
| tests/Unit/Provider/AdapterFactoryQueueProviderTest.php | Adds getNames() tests. |
| tests/Unit/Debug/QueueProviderInterfaceProxyTest.php | Adds proxy getNames() test. |
| tests/Unit/Command/RunCommandTest.php | Partially updates default-queue test to new behavior/signature (needs further fixes). |
| tests/Unit/Command/ListenAllCommandTest.php | Updates to new constructor signature using PredefinedQueueProvider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.