chore: fix test warnings across test suite #1468
Open
WilliamBergamin wants to merge 7 commits intomainfrom
Open
chore: fix test warnings across test suite #1468WilliamBergamin wants to merge 7 commits intomainfrom
WilliamBergamin wants to merge 7 commits intomainfrom
Conversation
WilliamBergamin
added
python
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 229 229
Lines 7266 7266
=======================================
Hits 6635 6635
Misses 631 631 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Mar 20, 2026
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin Another amazing change in care for this project 🧪 ✨
Please merge when's right but I left a curious question if the answer is quick-
Comment on lines
4
to
+5
| "ENGINE": "django.db.backends.sqlite3", | ||
| "NAME": "logs/db.sqlite3", | ||
| "NAME": ":memory:", |
Member
There was a problem hiding this comment.
👁️🗨️ question: Does this sqlite implementation not use the file system? I haven't explored these tests much but found this surprising at glance!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix some warnings that were showing up in our unit tests 🙏
Testing
CI should be sufficient
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.