Use sip-build and python3_add_library for Qt5/Qt6#157
Open
Use sip-build and python3_add_library for Qt5/Qt6#157
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Contributor
Author
|
|
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm playing around with an alternative to #143.
Requires ros/rosdistro#50338
If I understand correctly, and I'm not sure that I do,
python_qt_bindinguses a Python scriptsip_configure.pyto produce a Makefile that produces a cPython extension.#143 uses sip-build, but sets it up to use
pip installto generate the bindings. It ends up creating a separate functionbuild_sip_6_bindingto use this new approach with a configurable pyproject.toml.in template downstream inqt_gui_core.This PR uses
sip-buildand the CMake functionpython3_add_libraryto build a cPython extension instead. This PR allows using sip-build on both Qt5 and Qt6 bindings, though right now I've only tested it with Qt5 on Noble. I'll need to update the Python code like @ahcorde has in #143 to import from PyQt6.I used Gemini 3.1 Pro to help make this PR