Conversation
* Add `Final` * Add default values * Use `bool | Literal[0, 1]` for boolean params (instead of `int`) * Annotate known parts (Source: https://github.com/mhammond/pywin32/tree/b311/com/win32com)
| @type_check_only | ||
| class _DispatchCreateClass(Protocol[_T_co]): |
There was a problem hiding this comment.
cc @brianschubert I didn’t find any occurrences of this name in the source code (via grep), so I thought this case might also be interesting for your stubtest patch.
There was a problem hiding this comment.
Looks like this is covered by an allowlist entry, which is why it hasn't been flagged yet:
typeshed/stubs/pywin32/@tests/stubtest_allowlist_win32.txt
Lines 14 to 15 in 50ec910
Maybe you can refine that while we're here?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
brianschubert
left a comment
brianschubert
left a comment
There was a problem hiding this comment.
LGTM, thanks! Minor remarks below
I'd be nice to to see stubtest run on win32com.client.dynamic and win32com.client.gencache if that's now possible. I don't quite understand why their excluded at the moment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
2 participants
Finalbool | Literal[0, 1]for boolean params (instead ofint)(Source: https://github.com/mhammond/pywin32/tree/b311/com/win32com)