Enable using api.parser(trim=True)#644
Open
EtiennePelletier wants to merge 2 commits intopython-restx:masterfrom
Open
Enable using api.parser(trim=True)#644EtiennePelletier wants to merge 2 commits intopython-restx:masterfrom
EtiennePelletier wants to merge 2 commits intopython-restx:masterfrom
Conversation
themavik
reviewed
Mar 23, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Single test: Namespace.parser passes kwargs.
themavik
reviewed
Mar 23, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Namespace.parser(**kwargs) delegating to RequestParser(**kwargs) matches Api.parser; test_api_shortcut_kwargs covers trim=True. nit: assert parser.trim is True reads cleaner than == True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Namespace.parsershortcut is quite useful, but does not allow using different RequestParser kwargs than the default values currently. In some cases, I think doingapi.parser(trim=True)would be cleaner than separately importing RequestParser to access this functionality.I am suggesting a mini change to enable just that, which is fully backwards-compatible.
🐍 🤹♂️