Change syntax error handling from Exit to Continue#282
Merged
Conversation
Parser errors returned ExecuteResult::Exit which caused the interactive loop to call std::process::exit(). Changed to ExecuteResult::Continue so the shell shows the error and returns to the prompt instead of exiting. https://claude.ai/code/session_01FWuvp3gzrVXafUFScojkFZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the error handling behavior when a syntax error occurs during shell execution. Instead of immediately exiting with status code 1, the shell now continues execution while still returning the error code.
Key Changes
ExecuteResult::Exit(1, vec![], vec![])toExecuteResult::Continue(1, vec![], vec![])in the syntax error handlerImplementation Details
The change affects the error path in
execute_inner()when a syntax error is caught during parsing. The exit code (1) and empty output vectors are preserved, maintaining the error signal while changing the control flow behavior to continue rather than exit.https://claude.ai/code/session_01FWuvp3gzrVXafUFScojkFZ