Conversation
…ing the correct CORS policy to be set
…into portml * 'portml' of https://github.com/openml/openml-docker-dev: Removed quotation marks in http.cors.allow-headers: which are preventing the correct CORS policy to be set
…sword from docker-compose.yml
…ations and data volumes are created for docker and can be used in AWS
…tructure in this folder
New website is now copied from external folder in order to quickly change front-end using docker-compose args variable -sourceDirectory
…s to limit further configuration leaks
…be erased by Slack also updated the AWS template and Dockerfile
MatsPortML
approved these changes
Aug 5, 2022
|
Are you planning to include MinIO in this docker image as well? |
Contributor
|
For context: when requesting datasets, the API gives links to parquet files which (currently) depend on a minio service. |
|
Comments regarding MinIO: This is something we did not consider at the moment of this PR. But have been looking at it more recently. It would be great to have a small meeting to discuss how MinIO is used in the production environment for OpenML, based on that we can then implement it for the docker env and for PortML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.