Skip to content

test: scale keepAliveTimeoutBuffer with platformTimeout#62364

Open
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix-flaky-keepalive-timeout-tests
Open

test: scale keepAliveTimeoutBuffer with platformTimeout#62364
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix-flaky-keepalive-timeout-tests

Conversation

@geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Mar 21, 2026

Fixes #60656

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 21, 2026
@geeksilva97 geeksilva97 marked this pull request as ready for review March 21, 2026 15:17
@geeksilva97 geeksilva97 added the review wanted PRs that need reviews. label Mar 21, 2026
@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (68d7b6f) to head (a1e999f).
⚠️ Report is 355 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62364      +/-   ##
==========================================
- Coverage   89.77%   89.66%   -0.12%     
==========================================
  Files         673      676       +3     
  Lines      203820   206693    +2873     
  Branches    39175    39578     +403     
==========================================
+ Hits       182987   185332    +2345     
- Misses      13152    13494     +342     
- Partials     7681     7867     +186     

see 252 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: keepAliveTimeoutBuffer should be common.platformTimeout(1000)

2 participants