feat(php): configure Redis session handling via environment variables#2550
Draft
joshtrichards wants to merge 4 commits intomasterfrom
Draft
feat(php): configure Redis session handling via environment variables#2550joshtrichards wants to merge 4 commits intomasterfrom
joshtrichards wants to merge 4 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Fixes #763 Implements part I of #763 (comment) Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
feature: auto config (environment variables)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763
Configure existing
REDIS_*image configuration variables as they exist today (no changes).For standard environments (i.e. those that already work today with the existing implementation), the result should be:
For environments running containers w/o root:
This is a prototype in its current state.
Key things to confirm:
P.S. If the empty values being always passed through is problematic.... This tests the full “drop redis-session.ini entirely” idea. If this runs into challenges, we could generate a separate ini file (only when Redis is configured) in the entrypoint, but still source values from env. That would test the env-based composition separately from the fallback problem.