Fix potential leak in JSValue assignment#7814
Open
eddyashton wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix potential leak in JSValue assignment#7814eddyashton wants to merge 2 commits intomicrosoft:mainfrom
eddyashton wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential memory leak in the QuickJS JSValue wrapper by ensuring previously-held values are released during copy-assignment, and adds a unit test to validate ref-count behavior.
Changes:
- Free the currently-held
JSValueinJSWrappedValue::operator=(const JSWrappedValue&)before duplicating the new value. - Add a doctest that checks QuickJS ref-counts decrease/increase as expected across copy-assignment and destruction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/js/core/wrapped_value.cpp |
Fixes JSWrappedValue copy-assignment to release the old value before overwriting it. |
src/js/test/js.cpp |
Adds a regression test asserting correct QuickJS ref-count behavior for copy-assignment. |
maxtropets
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.