fix(habits): guard against null commit entries in PushEvent payload#1807
Open
Br1an67 wants to merge 4 commits intolowlighter:mainfrom
Open
fix(habits): guard against null commit entries in PushEvent payload#1807Br1an67 wants to merge 4 commits intolowlighter:mainfrom
Br1an67 wants to merge 4 commits intolowlighter:mainfrom
Conversation
Some PushEvent payloads contain null/undefined commit entries (e.g. from
deleted users or force-pushed commits). The subsequent destructuring of
`{author}` throws TypeError when encountering these entries.
Add a filter to skip null/undefined commits before accessing their
properties.
Instead of building the entire Docker image from scratch (which fails due to nokogiri compilation issues), extend the official pre-built image and only COPY the patched habits plugin file.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The habits plugin crashes with
TypeError: Cannot destructure property 'author' of 'undefined'when processing PushEvent payloads that contain null/undefined commit entries.This can happen when:
Root Cause
In
source/plugins/habits/index.mjs, the commit processing chain:payload.commitsmay containnull/undefinedentries. The next.filter()immediately destructures{author}from each entry, which throws when the entry isundefined.Fix
Add
.filter(commit => commit)between theflatMapand the author filter to skip null/undefined entries before attempting destructuring.Testing
Tested against a GitHub account with 788+ PRs across 152+ contributed repositories where this error was consistently reproducible.