Conversation
Add `integration_tests_eclair.rs` with a `TestEclairClient` wrapping Eclair's HTTP REST API via `bitreq`, and a `test_eclair()` function exercising channel open/close, bidirectional BOLT11 payments, and soft-fail splice in/out tests. Also add `eclair_test` to the `check-cfg` list in `Cargo.toml` and to the cfg gate in `tests/common/mod.rs`. Generated with the help of AI (Claude Code). Co-Authored-By: HAL 9000
|
👋 I see @valentinewallace was un-assigned. |
Add `docker-compose-eclair.yml` running bitcoind (with ZMQ), electrs, and `acinq/eclair:v0.13.1`, and a GitHub Actions workflow that starts the containers and runs the Eclair integration test suite. Generated with the help of AI (Claude Code). Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
43673da to
cb73a18
Compare
|
Were you able to get this to work locally with ⏺ We found several bugs in the cherry-picked commits:
Unresolved: Eclair's ZMQ subscription doesn't receive messages when running in Docker on macOS, despite:
The issue appears specific to Eclair's Akka actor system interacting with jeromq inside Docker on macOS. I don't have a root cause. |
No, I never got it to work fully (not only macOS, but also not in CI) and didn't get back to look at it more closely yet. @febyeji however indicated to wanted to work on it as part of #766, so we might end up closing this PR. |
|
@tnull @jkczyz I'm working on this as part of an integration test harness PR for CLN, LND, and Eclair. Here's what I've found regarding the Eclair issues. Confirmed fixes:
Regarding macOS Docker, I also had a similar issue. Standalone ZMQ tests work fine between containers, but Eclair's internal ZMQ subscription fails on Docker bridge networking. I didn't find a root cause for this yet.
|
|
Thank you very much!
I think it's not that bad as long as the tests run properly in CI. However, it would of course be preferable for macOS-based devs to also run them locally, but we shouldn't probably block on that (i.e., when in doubt open an issue for it so we don't forget and keep things moving). |
No description provided.