netbsd: check not only addr 0 but also addr 1 to find root hubs#780
Merged
Youw merged 1 commit intolibusb:masterfrom Mar 20, 2026
Merged
Conversation
On NetBSD xhci(4) uses 'addr 0' for the root hub but all drivers for other host controllers use 'addr 1' for the root hub. https://gnats.netbsd.org/60073
There was a problem hiding this comment.
Pull request overview
Adjusts NetBSD HID device enumeration to find USB root hubs regardless of whether the controller presents the root hub at address 0 (xhci) or address 1 (most other host controllers), improving device discovery on NetBSD (per GNATS 60073).
Changes:
- Adds a two-step enumeration attempt: probe USB address 0 first, then fall back to address 1 if nothing was found.
- Introduces state tracking (
prev_end) to decide whether to attempt the fallback enumeration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Youw
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On NetBSD xhci(4) uses 'addr 0' for the root hub but all drivers for other host controllers use 'addr 1' for the root hub.
https://gnats.netbsd.org/60073
Tested with ch32fun on NetBSD/i386 10.1 both with xhci(4) and ohci(4).