fix: Litellm preserve streamed reasoning deltas in LiteLLM adapter#4952
Open
lorenzbaraldi wants to merge 2 commits intogoogle:mainfrom
Open
fix: Litellm preserve streamed reasoning deltas in LiteLLM adapter#4952lorenzbaraldi wants to merge 2 commits intogoogle:mainfrom
lorenzbaraldi wants to merge 2 commits intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
No existing issue linked for this fix.
Problem:
In
LiteLlmmessage conversion, reasoning parts were combined with newlineinjection:
reasoning_content = _NEW_LINE.join(text for text in reasoning_texts if text)For providers that stream reasoning in delta fragments (for example, vLLM-style
reasoning chunks), this mutates the original stream by inserting extra
separators. The reconstructed reasoning can differ compared to provider
output.
Solution:
Preserve reasoning text exactly as streamed by concatenating fragments without
adding separators:
reasoning_content = "".join(text for text in reasoning_texts if text)This avoids corruption of chunked reasoning while still preserving explicit
newlines already present in fragments.
Also added targeted regression tests to lock behavior:
test_content_to_message_param_preserves_chunked_reasoning_deltastest_content_to_message_param_preserves_reasoning_newlinesTesting Plan
Unit Tests:
Summary of local
pytestruns:python -m pytest tests/unittests/models/test_litellm.py -k "content_to_message_param_assistant_thought_and_content_message or preserves_chunked_reasoning_deltas or preserves_reasoning_newlines"3 passed, 244 deselectedpython -m pytest tests/unittests/models/test_litellm.py -k "preserves_chunked_reasoning_deltas or preserves_reasoning_newlines"2 passed, 245 deselectedManual End-to-End (E2E) Tests:
Checklist
Additional context
Scope is intentionally minimal and low risk:
thinking_blockspath is unchanged.