fix: replace bare except with except Exception#4949
fix: replace bare except with except Exception#4949YouFoxGirl wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Use except Exception: instead of bare except: in the live agent API sample.
e0395af to
3bb383b
Compare
|
Response from ADK Triaging Agent Hello @YouFoxGirl, thank you for creating this PR! To help reviewers evaluate your contribution, could you please provide a "testing plan" section in your PR description explaining how you've tested these changes? Also, for bug fixes, we require an associated GitHub issue. If one doesn't exist, could you please create one and link it to this PR? This information will help us review your PR more efficiently. Thanks! |
What this PR does
Replace bare
except:clauses withexcept Exception:to avoid catchingKeyboardInterruptandSystemExit. Added a TODO note for futuremore specific exception handling where applicable.
Why this matters
Bare
except:catches all exceptions includingKeyboardInterruptand
SystemExit, which can hide bugs and make debugging harder.