Open
Conversation
Collaborator
|
Hi @noah082011 , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Collaborator
|
Hi @Jacksunwei , can you please review this. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
#4890
2. Or, if no issue exists, describe the change:
Problem:
When initializing the DatabaseSessionService, the log message used the phrase "Falling back to...", which implies a failure or an unintended state. This caused confusion during debugging when a database URI was intentionally provided.
Solution:
Updated the log message in service_factory.py to say "Using DatabaseSessionService..." to accurately reflect that the service is being initialized as intended.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.All unit tests for service_factory.py pass locally
Manual End-to-End (E2E) Tests:
Initialize the ADK CLI using a metadata database URI
The log should now display INFO - Using DatabaseSessionService... instead of the previous "Falling back to..." message.
Checklist
Additional context
Add any other context or screenshots about the feature request here.