Refactor inclusion of compiler libraries#42
Merged
AlexanderLanin merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
nradakovic
force-pushed
the
nira_ref_ld_path
branch
2 times, most recently
from
0e95362 to
6d4586f
Compare
nradakovic
force-pushed
the
nira_ref_ld_path
branch
2 times, most recently
from
6e989ae to
98a78ee
Compare
nradakovic
requested review from
AlexanderLanin,
antonkri and
dcalavrezo-qorix
as code owners
nradakovic
force-pushed
the
nira_ref_ld_path
branch
from
98a78ee to
be06e8e
Compare
opajonk
approved these changes
Mar 20, 2026
Contributor
opajonk
left a comment
opajonk
left a comment
There was a problem hiding this comment.
LGTM; the approach is better since it avoids changing all Linux toolchain definitions.
AlexanderLanin
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation requires that all toolchains packages define ld_library_path which is not optimal since only one toolchain (so far) needs this field. We will move it to template and it's up to the toolchain package maintaner to set it or not.