docker stats: assorted fixes and optimizations in rendering#6876
Open
thaJeztah wants to merge 4 commits intodocker:masterfrom
Open
docker stats: assorted fixes and optimizations in rendering#6876thaJeztah wants to merge 4 commits intodocker:masterfrom
thaJeztah wants to merge 4 commits intodocker:masterfrom
Conversation
Move logic to capture a snapshot of the current stats to the stats struct. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This code is using a `bytes.Buffer` to render the stats, before writing the results to the CLI's output. Let's try to use bytes where possible instead of converting to a string; - Use the buffer's `Write` (and `Out().Write`) to write directly to the buffer/writer where possible. - Use `io.WriteString` instead of `fmt.Printf` - Use `bytes.SplitSeq` instead of `strings.SplitSeq` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command/container: stats: add snapshot method
Move logic to capture a snapshot of the current stats to the stats struct.
cli/command/container: RunStats: rename buffer var for brevity
cli/command/container: RunStats: avoid bytes to strings conversions
This code is using a
bytes.Bufferto render the stats, before writingthe results to the CLI's output. Let's try to use bytes where possible
instead of converting to a string;
Write(andOut().Write) to write directly to thebuffer/writer where possible.
io.WriteStringinstead offmt.Printfbytes.SplitSeqinstead ofstrings.SplitSeqcli/command/container: statsFormatWrite: inline render func
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)