-
Notifications
You must be signed in to change notification settings - Fork 3
Setup for optional django dependency and unit testing with/without django #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rlskoeser
wants to merge
9
commits into
develop
Choose a base branch
from
feature/optional-django
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d1b29ba
Add django optional dependency group and add new undate.django module
rlskoeser 9995a95
Add django to unit test build matrix
rlskoeser 8618048
Document optional django install
rlskoeser e42bdf8
Add django pytest skip decorators & placeholder unit tests to confirm
rlskoeser 0830ef3
Add typing to optional django import
rlskoeser f2237ae
Require newer version of numpy and remove deprecated typing plugin
rlskoeser b2084d0
Change non-django matrix build check, per coderabbitai review
rlskoeser dc05124
Drop numpy version from check (conflicts with python versions in build)
rlskoeser 729e6d8
Add pip to check requirements, since not installed with uv by default
rlskoeser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| """ | ||
| Utility decorators for unit tests that require django to be installed, | ||
| or not installed. To use, import into unit test and apply | ||
| to test method or class: | ||
|
|
||
| ```python | ||
|
|
||
| from undate.test_utils import skipif_no_django, skipif_django | ||
|
|
||
| @skipif_no_django | ||
| def test_django_functionality(): | ||
| .... | ||
| ``` | ||
|
|
||
| """ | ||
|
|
||
| import pytest | ||
|
|
||
| try: | ||
| import django | ||
| except ImportError: | ||
| django = None | ||
|
|
||
| skipif_no_django = pytest.mark.skipif(django is None, reason="requires Django") | ||
|
|
||
| skipif_django = pytest.mark.skipif(django, reason="requires no Django") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| try: | ||
| import django | ||
| except ImportError: | ||
| django = None | ||
|
|
||
| from undate.test_utils import skipif_no_django, skipif_django | ||
|
|
||
|
|
||
| @skipif_no_django | ||
| def test_django(): | ||
| assert django is not None | ||
|
|
||
|
|
||
| @skipif_django | ||
| def test_no_django(): | ||
| assert django is None |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.