feat: make supported chains list dynamic via getSupportedChains API#1239
Open
stephancill wants to merge 1 commit intobase:masterfrom
Open
feat: make supported chains list dynamic via getSupportedChains API#1239stephancill wants to merge 1 commit intobase:masterfrom
stephancill wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
5e6a7cb to
3ad888d
Compare
3ad888d to
57696ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The supported chains list was hardcoded in two places with inconsistencies between them. This PR:
docs/snippets/supported-chains.mdxsnippet used by both the Base Account overview and mini-apps compatibility pagesscripts/update-supported-chains.shthat fetches the SCWgetSupportedChainsAPI and injects any chains taggedsimple-chaininto the snippetsimple-chain) are dynamicNotes to reviewers
No
simple-chaintags exist in prod yet, so the dynamic section is currently empty. When basic chains are tagged in scw-manager, running the script will populate them. Tested against the dev API (wallet-api-dev.cbhq.net) where Monad, Unichain, and ZKsync are tagged.The script supports an
API_URLenv var override for testing:API_URL=https://wallet-api-dev.cbhq.net/rpc/v3/scw/getSupportedChains bash scripts/update-supported-chains.shHow has it been tested?
Ran
mintlify devlocally and verified rendering with both prod API (no basic chains) and dev API (Monad, Unichain, ZKsync shown).