Skip to content

Add Cython coverage#12349

Open
Dreamsorcerer wants to merge 43 commits intomasterfrom
cython-cov
Open

Add Cython coverage#12349
Dreamsorcerer wants to merge 43 commits intomasterfrom
cython-cov

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added the backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot label Apr 10, 2026
@webknjaz
Copy link
Copy Markdown
Member

Does this actually work? I know it got broken and stopped working in other projects.. I haven't figured out why.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.91%. Comparing base (f55503d) to head (2330dad).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12349      +/-   ##
==========================================
- Coverage   99.11%   98.91%   -0.21%     
==========================================
  Files         130      133       +3     
  Lines       45626    46257     +631     
  Branches     2405     2405              
==========================================
+ Hits        45224    45754     +530     
- Misses        272      373     +101     
  Partials      130      130              
Flag Coverage Δ
CI-GHA 98.97% <ø> (ø)
OS-Linux 98.72% <ø> (ø)
OS-Windows 96.97% <ø> (+<0.01%) ⬆️
OS-macOS 97.87% <ø> (ø)
Py-3.10.11 97.43% <ø> (+<0.01%) ⬆️
Py-3.10.20 97.90% <ø> (+<0.01%) ⬆️
Py-3.11.15 98.10% <ø> (-0.01%) ⬇️
Py-3.11.9 97.63% <ø> (ø)
Py-3.12.10 97.72% <ø> (ø)
Py-3.12.13 98.20% <ø> (ø)
Py-3.13.12 98.45% <ø> (ø)
Py-3.14.3 98.51% <ø> (+<0.01%) ⬆️
Py-3.14.4t 97.51% <ø> (ø)
Py-pypy3.11.15-7.3.21 97.38% <ø> (+<0.01%) ⬆️
VM-macos 97.87% <ø> (ø)
VM-ubuntu 98.72% <ø> (ø)
VM-windows 96.97% <ø> (+<0.01%) ⬆️
cython-coverage 37.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 10, 2026

Merging this PR will not alter performance

✅ 61 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing cython-cov (2330dad) with master (f55503d)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Does this actually work? I know it got broken and stopped working in other projects.. I haven't figured out why.

No idea, that's what codecov is for. A quick test locally suggested that coverage was getting reported.

@webknjaz
Copy link
Copy Markdown
Member

Oh, and Cython needs to be installed into the same env as coveragepy for it to be able to load that plugin.

@Dreamsorcerer Dreamsorcerer marked this pull request as draft April 10, 2026 23:24
@Dreamsorcerer
Copy link
Copy Markdown
Member Author

There seem to be some tests which completely cripple the performance. I think the only reasonable option would be to use a separate job that disables blockbuster and runs a subset of the test suite with tracing.

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Doesn't seem to be making it to codecov at all anyway..

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

There is definitely coverage when running these steps locally. Can't find any reason why this is not producing coverage in CI....

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Cython tracing is broken on Python 3.13+ due to https://peps.python.org/pep-0669/
Need to rely on Python 3.12 until that is hopefully resolved.

@Dreamsorcerer Dreamsorcerer marked this pull request as ready for review April 11, 2026 17:35
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants