Fix blog route matching article header#769
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced the article header image: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6964b7c572
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/blog/tanstack-router-route-matching-tree-rewrite.md`:
- Line 9: The image markdown currently uses a generic alt text "Header" in the
line containing
"";
replace that alt text with a meaningful description (e.g., "Fantasy landscape
illustration used as the article header") or make it decorative by using an
empty alt (``), updating the markdown line
accordingly so screen readers receive either the descriptive text or treat the
image as decorative.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d5adcc53-e648-4fae-a1ed-ecf8e6cfea9c
⛔ Files ignored due to path filters (2)
public/blog-assets/tanstack-router-route-matching-tree-rewrite/big-number.pngis excluded by!**/*.pngpublic/blog-assets/tanstack-router-route-matching-tree-rewrite/header.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/blog/tanstack-router-route-matching-tree-rewrite.md
Just adding a header image because with the new layout, the previous one just wasn't nice anymore (wasn't the best before either)
before

after

Summary by CodeRabbit