Draft
Conversation
Defaulting to null without being nullable (?Foo) is deprecated for typed parameters in PHP 8.4 Therefore following changes have been made: * `IncludeFile`: We actually do not need a Filesystem parameter for `IncludeFile. It has never been passed and is therefore removed. * `ClassAliasMapGenerator` `Config` parameter is unused (was never set) since the introduction in a63a582. It is removed. * `ClassAliasMapGenerator` `IO` parameter has always been set and is therefore now a required parameter. Additional the call to str_getcsv is adapted to set all optional arguments as the defaults will change in PHP >= 9 and PHP 8.4 deprecated the omission of the optional arguments. Fixes TYPO3#31
Also drop prophecy workarounds since PHP 8.2 compatibility has been enabled upstream.
Member
Author
|
I think this refactoring would be good for the codebase, but applying I'll provide a second PR for that so we can decide which one we take. |
Contributor
|
@bnf I think this tiny refactoring still makes sense. I'd keep PHP 7.1 minimum though. So if you would give this a shot, I'd merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
composer upgrade