Skip to content

Handle double clicking a checkbox #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SharonStrats wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Handle double clicking a checkbox #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/widgets/forms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1879,7 +1879,14 @@ export function buildCheckboxForm (dom, kb, lab, del, ins, form, dataDoc, trista
refresh()
if (!editable) return box

let isUpdating = false // Prevent concurrent updates on double-click

const boxHandler = function (_e) {
if (isUpdating) {
return // Ignore clicks while update is in progress
}
isUpdating = true
input.disabled = true // Disable button to provide user feedback
Comment on lines +1882 to +1889
colorCarrier.style.color = '#bbb' // grey -- not saved yet
const toDelete = input.state === true ? ins : input.state === false ? del : []
input.newState =
Expand All @@ -1900,6 +1907,8 @@ export function buildCheckboxForm (dom, kb, lab, del, ins, form, dataDoc, trista
success,
errorBody
) {
isUpdating = false
input.disabled = false
if (!success) {
if (toDelete.why) {
const hmmm = kb.holds(
Expand Down
Loading