Skip to content

Introduce datatable.unique.names policy for duplicate handling in setnames() #4044#7674

Open
venom1204 wants to merge 3 commits intomasterfrom
issue4044
Open

Introduce datatable.unique.names policy for duplicate handling in setnames() #4044#7674
venom1204 wants to merge 3 commits intomasterfrom
issue4044

Conversation

@venom1204
Copy link
Contributor

Closes #4044

Hi @ben-schwen,

Apologies for opening a new PR—there was an issue with the previous one. I’ve incorporated the requested changes, while keeping the rest unchanged.

Kindly review it when you have the time. Also, sorry for the delay; I was occupied with other commitments.

Thank you!

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (7db13b9) to head (471ab20).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7674   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          87       87           
  Lines       17031    17049   +18     
=======================================
+ Hits        16868    16886   +18     
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

No obvious timing issues in HEAD=issue4044
Comparison Plot

Generated via commit 471ab20

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 53 seconds
Installing different package versions 23 seconds
Running and plotting the test cases 4 minutes and 3 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should setnames() produce duplicate column names without warning?

1 participant