Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When information about the content are sent to the client, it does not know whether it gets info. for the latest version of the content or for an older one.
Client could speculate the availability based on what it has asked server for or the string representation of the version that we already send, but both of this solutions would be inaccurate.
The one based on what client has asked server for, would rely on timing and break with slow internet connection and increasing number of content.
The version solution, would rely on compering string version from server with int version contained inside the grf file that the user has already downloaded. Different GRF autors use different systems for representing the version number as a string.
So just send the information about availability at the end of message which maintains backward compatibility.