tech: enable watch mode & esbuild server in dev mode#674
Open
ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
Open
tech: enable watch mode & esbuild server in dev mode#674ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
Conversation
clemgbld
requested review from
PierreDemailly and
fraxken
and removed request for
fraxken
Member
|
Not a big fan of duplicating code (http etc) |
fraxken
reviewed
Mar 11, 2026
Contributor
Author
i ended up removing duplication. |
ErwanRaulo
force-pushed
the
watch-mode
branch
2 times, most recently
from
2971aff to
83933fe
Compare
ErwanRaulo
force-pushed
the
watch-mode
branch
4 times, most recently
from
ad135d8 to
df46649
Compare
ErwanRaulo
commented
Mar 21, 2026
| defaultScannerCommand("auto [spec]", { includeOutput: false, strategy: vulnera.strategies.GITHUB_ADVISORY }) | ||
| .describe(i18n.getTokenSync("cli.commands.auto.desc")) | ||
| .option("-k, --keep", i18n.getTokenSync("cli.commands.auto.option_keep"), false) | ||
| .option("-d, --developer", i18n.getTokenSync("cli.commands.open.option_developer"), false) |
Contributor
Author
There was a problem hiding this comment.
conflicts with -d of --depth, giving Infinity as value instead of boolean.
dev mode was always enabled.
Member
There was a problem hiding this comment.
Think to update the documentation (./docs/cli) for commands such as auto, etc
ErwanRaulo
force-pushed
the
watch-mode
branch
4 times, most recently
from
5e2558f to
b008493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what it does
add esbuild dev config to watch and serve fle for auto reload on served files changes.
features
tests
commands tested : nsecure auto
[x] tests pass
to validate:
to fix: