From 30546b03cbfb6ea96bcac6b33a760fbf5550363f Mon Sep 17 00:00:00 2001 From: phani Date: Tue, 17 Mar 2026 14:37:51 -0400 Subject: [PATCH] fix: allow replays list/download for deleted browser sessions The CLI was calling GET /browsers/{id} before listing or downloading replays, which returns 404 for deleted sessions. Skip that lookup and pass the session ID directly to the replay endpoints, which already work for deleted sessions. Fixes KERNEL-1098 --- cmd/browsers.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/cmd/browsers.go b/cmd/browsers.go index ea9c1c9..d264922 100644 --- a/cmd/browsers.go +++ b/cmd/browsers.go @@ -1092,11 +1092,7 @@ func (b BrowsersCmd) ReplaysList(ctx context.Context, in BrowsersReplaysListInpu return fmt.Errorf("unsupported --output value: use 'json'") } - br, err := b.browsers.Get(ctx, in.Identifier, kernel.BrowserGetParams{}) - if err != nil { - return util.CleanedUpSdkError{Err: err} - } - items, err := b.replays.List(ctx, br.SessionID) + items, err := b.replays.List(ctx, in.Identifier) if err != nil { return util.CleanedUpSdkError{Err: err} } @@ -1165,11 +1161,7 @@ func (b BrowsersCmd) ReplaysStop(ctx context.Context, in BrowsersReplaysStopInpu } func (b BrowsersCmd) ReplaysDownload(ctx context.Context, in BrowsersReplaysDownloadInput) error { - br, err := b.browsers.Get(ctx, in.Identifier, kernel.BrowserGetParams{}) - if err != nil { - return util.CleanedUpSdkError{Err: err} - } - res, err := b.replays.Download(ctx, in.ReplayID, kernel.BrowserReplayDownloadParams{ID: br.SessionID}) + res, err := b.replays.Download(ctx, in.ReplayID, kernel.BrowserReplayDownloadParams{ID: in.Identifier}) if err != nil { return util.CleanedUpSdkError{Err: err} }